Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): Add Admin UI test for OIDC auth method #2638

Merged
merged 4 commits into from
Jan 3, 2025
Merged

test(e2e): Add Admin UI test for OIDC auth method #2638

merged 4 commits into from
Jan 3, 2025

Conversation

moduli
Copy link
Collaborator

@moduli moduli commented Dec 20, 2024

Description

This PR adds an e2e test for creating an OIDC auth method. This test can be run using CE and ENT editions against either docker or AWS infrastructure.

Screenshots (if appropriate)

oidc.mov

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

https://hashicorp.atlassian.net/browse/ICU-16068

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 6:41pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 6:41pm

@moduli moduli force-pushed the moduli-e2e-vault-oidc branch from 8930a77 to 127c8cb Compare December 20, 2024 19:37
@moduli moduli requested review from ZedLi and calcaide December 20, 2024 19:43
@moduli moduli marked this pull request as ready for review December 20, 2024 19:43
@moduli moduli requested a review from a team as a code owner December 20, 2024 19:43
@moduli moduli force-pushed the moduli-e2e-vault-oidc branch from 127c8cb to 3ed8deb Compare December 20, 2024 19:44
@moduli moduli force-pushed the moduli-e2e-vault-oidc branch from 3ed8deb to 3fdffe6 Compare January 3, 2025 17:44
ZedLi
ZedLi previously approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works great! Mentioned it in DMs but it sounds like we'll have to update the dropdown locators later as they've been updated since the last version in boundary

e2e-tests/admin/tests/auth-method-ldap.spec.js Show resolved Hide resolved
e2e-tests/admin/tests/auth-method-ldap.spec.js Outdated Show resolved Hide resolved
@moduli moduli requested a review from ZedLi January 3, 2025 18:38
@moduli moduli force-pushed the moduli-e2e-vault-oidc branch from 01727bc to 2ffa44f Compare January 3, 2025 18:38
@moduli moduli merged commit ca4aad0 into main Jan 3, 2025
12 checks passed
@moduli moduli deleted the moduli-e2e-vault-oidc branch January 3, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZedLi ZedLi ZedLi approved these changes

@calcaide calcaide Awaiting requested review from calcaide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moduli @ZedLi